Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] backend_args should not be modified by get_file_backend #897

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Feb 1, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

>>> import mmengine.fileio as fileio
>>> backend_args = {'backend': 'local'}
>>> res = fileio.get(filepath, backend_args=backend_args)
>>> backend_args
{}

backend key in backend_args will be popped and it will cause the program to fail when users use it again.

Modification

copy backend_args before popping it.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@c46f891). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7e30ec1 differs from pull request most recent head 64f1745. Consider uploading reports for the commit 64f1745 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage        ?   78.22%           
=======================================
  Files           ?      132           
  Lines           ?    10004           
  Branches        ?     1998           
=======================================
  Hits            ?     7826           
  Misses          ?     1839           
  Partials        ?      339           
Flag Coverage Δ
unittests 78.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida requested a review from C1rN09 February 1, 2023 03:21
@zhouzaida zhouzaida merged commit 5753cd9 into open-mmlab:main Feb 1, 2023
@zhouzaida zhouzaida deleted the fix-fileio branch February 1, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants