-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Substitute the environment variable in config file. #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the config tutorial after the document refactoring. I'll make a notification when it is ready to update the config tutorial.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=======================================
Coverage ? 78.24%
=======================================
Files ? 132
Lines ? 9997
Branches ? 1997
=======================================
Hits ? 7822
Misses ? 1837
Partials ? 338
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need to update config tutorial now or waiting for document refactoring finished? |
Document refactoring has been finished! You can update the tutorial now 😄 ~ |
在 Windows 环境中 如果有个环境变量包含windows路径,如下:
返回错误 |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Enable using environment variables in config files. Can make config more flexible.
Example 1
demo_config.py
test.py
The results of this pr are as below:
Example 2
demo_config.py
The results of this pr are as below:
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist