-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Call register_all_modules
in Registry.get()
#541
Merged
zhouzaida
merged 7 commits into
open-mmlab:main
from
HAOCHENYE:HAOCHENYE/enhance_registry
Oct 24, 2022
Merged
[Enhance] Call register_all_modules
in Registry.get()
#541
zhouzaida
merged 7 commits into
open-mmlab:main
from
HAOCHENYE:HAOCHENYE/enhance_registry
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harold-lkk
previously approved these changes
Oct 21, 2022
Harold-lkk
reviewed
Oct 21, 2022
fangyixiao18
previously approved these changes
Oct 24, 2022
zhouzaida
reviewed
Oct 24, 2022
Co-authored-by: Zaida Zhou <[email protected]>
zhouzaida
changed the title
[Ehance] Call
[Enhance] Call Oct 24, 2022
register_all_modules
in Registry.get()
register_all_modules
in Registry.get()
zhouzaida
previously approved these changes
Oct 24, 2022
Harold-lkk
previously approved these changes
Oct 24, 2022
RangiLyu
previously approved these changes
Oct 24, 2022
RangiLyu
reviewed
Oct 24, 2022
RangiLyu
reviewed
Oct 24, 2022
RangiLyu
reviewed
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the typos
zhouzaida
approved these changes
Oct 24, 2022
C1rN09
pushed a commit
to C1rN09/mmengine
that referenced
this pull request
Nov 1, 2022
…#541) * call register_all_modules in Registry.get() * Fix ci * fix scope bug (scope_name -> scope), for temp sync * Fix unit test * Refine log information Co-authored-by: Zaida Zhou <[email protected]> * Fix typo Co-authored-by: Zaida Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
If we use config like this:
MODELS.build(model)
will NOT regist modules ofmmcl
, and we need to setcustom_configs=...
in config file extraly.However, if we set
_scope_
in config:The modules of
mmcls
will be registered, and its behavior is inconsistent withtype=mmcls.ResNet
.Therefore, this pr make
type=mmcls.ResNet
will also trigger the regist process.Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist