Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove MinkowskiEngine ImportError warnings #1682

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Aug 1, 2022

Motivation

MinkowskiEngine is an extra requirement. We do not want to spam not using MinkowskiEngine users with warnings from all python files where it is imported (on every run of mmdetection3d).

Modification

Just remove warning when MinkowskiEngine is not installed.

BC-breaking (Optional)

No.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Aug 1, 2022

Lint issues should be fixed.

@filaPro
Copy link
Contributor Author

filaPro commented Aug 1, 2022

Can fix, but affected files are not modified in this PR...

I've reinstall linter with latest pre-commit config but it still doesn't see the problems mentioned in failed build logs.

@Tai-Wang
Copy link
Member

Tai-Wang commented Aug 3, 2022

Yes, it's really strange, but could you please fix the problem mentioned in the lint check by the way? And If more problems appear afterward we will just directly merge this PR first.

@filaPro
Copy link
Contributor Author

filaPro commented Aug 3, 2022

I've somehow fixed lint, but it can be too annoying int the future... Should we synchronize lint configs in CI and pre-commit-config.yml? mmcv version in CI should probably also been fixed.

@Tai-Wang
Copy link
Member

Tai-Wang commented Aug 4, 2022

I've somehow fixed lint, but it can be too annoying int the future... Should we synchronize lint configs in CI and pre-commit-config.yml? mmcv version in CI should probably also been fixed.

OK, I agree. We will fix them in the release PR.

@Tai-Wang Tai-Wang merged commit 3abd973 into open-mmlab:dev Aug 4, 2022
@filaPro filaPro deleted the fix_minkowski_warnings branch August 4, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants