Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the requirement of mmcv and mmdet #1537

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

Tai-Wang
Copy link
Member

@Tai-Wang Tai-Wang commented Jun 7, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Due to the update of mmcv requirement in mmdet, mmdet3d also needs to update the requirement of mmcv and mmdet in the requirement files and getting_started doc.

Modification

Please briefly describe what modification is made in this PR.

  • Update the version of mmcv and mmdet in the requirements
  • Update the getting_started doc

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Tai-Wang Tai-Wang changed the base branch from master to dev June 7, 2022 04:20
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@e252ff5). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev    #1537   +/-   ##
======================================
  Coverage       ?   50.38%           
======================================
  Files          ?      221           
  Lines          ?    18929           
  Branches       ?     3118           
======================================
  Hits           ?     9538           
  Misses         ?     8814           
  Partials       ?      577           
Flag Coverage Δ
unittests 50.38% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e252ff5...966de84. Read the comment docs.

@Tai-Wang Tai-Wang requested a review from ZwwWayne June 7, 2022 14:36
@ZwwWayne ZwwWayne merged commit c232b7a into open-mmlab:dev Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants