Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch back to original pycocotools #6838

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

fcakyon
Copy link
Contributor

@fcakyon fcakyon commented Dec 20, 2021

Windows installation (compilation settings) were missing on the original pycocotools package so we started to using pycocotools-windows package for windows.

Now Windows installation is fixed on the original pycocotools pypi package, so we can update the dependency.

Fixes #4939 (comment)

windows installation is fixed on the original pycocotools pypi package, so we can update the dependency
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #6838 (1297dfc) into master (83eea4b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6838      +/-   ##
==========================================
- Coverage   62.00%   61.98%   -0.02%     
==========================================
  Files         322      322              
  Lines       25717    25717              
  Branches     4356     4356              
==========================================
- Hits        15945    15941       -4     
- Misses       8921     8929       +8     
+ Partials      851      847       -4     
Flag Coverage Δ
unittests 61.96% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 68.06% <0.00%> (-1.41%) ⬇️
mmdet/models/dense_heads/base_dense_head.py 90.39% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83eea4b...1297dfc. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 3335d82 into open-mmlab:master Dec 22, 2021
@AronLin AronLin mentioned this pull request Dec 27, 2021
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
windows installation is fixed on the original pycocotools pypi package, so we can update the dependency
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
windows installation is fixed on the original pycocotools pypi package, so we can update the dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants