Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add Chinese version of 2_new_data_model #5618

Merged
merged 9 commits into from
Jul 20, 2021
Merged

[Docs] add Chinese version of 2_new_data_model #5618

merged 9 commits into from
Jul 20, 2021

Conversation

KainingYing
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

This PR adds Chinese version of 2_new_data_model

Modification

This PR adds Chinese version of 2_new_data_model

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2021

CLA assistant check
All committers have signed the CLA.

@KainingYing KainingYing changed the title [WIP] add Chinese version of 2_new_data_model [Docs] add Chinese version of 2_new_data_model Jul 15, 2021
Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a space between Chinese and English, So, Please check your PR

docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZwwWayne ZwwWayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @noobying , thanks for the efforts. The overall PR looks great. Some tweaks need to be resolved to make it more smooth. I also suggest we read it again to make it more straightforward and easy to read.

docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
@AronLin AronLin self-requested a review July 16, 2021 05:15
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #5618 (1e8ffc9) into master (475c6be) will decrease coverage by 0.38%.
The diff coverage is n/a.

❗ Current head 1e8ffc9 differs from pull request most recent head 920e23a. Consider uploading reports for the commit 920e23a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5618      +/-   ##
==========================================
- Coverage   66.02%   65.63%   -0.39%     
==========================================
  Files         279      279              
  Lines       21889    21740     -149     
  Branches     3629     3629              
==========================================
- Hits        14452    14269     -183     
- Misses       6675     6697      +22     
- Partials      762      774      +12     
Flag Coverage Δ
unittests 65.63% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/utils/contextmanagers.py 0.00% <0.00%> (-18.58%) ⬇️
mmdet/models/utils/normed_predictor.py 83.33% <0.00%> (-9.53%) ⬇️
mmdet/models/roi_heads/test_mixins.py 50.80% <0.00%> (-6.46%) ⬇️
mmdet/models/dense_heads/dense_test_mixins.py 38.46% <0.00%> (-5.13%) ⬇️
mmdet/models/detectors/base.py 53.65% <0.00%> (-2.50%) ⬇️
mmdet/models/roi_heads/base_roi_head.py 85.29% <0.00%> (-2.21%) ⬇️
mmdet/datasets/pipelines/formating.py 64.22% <0.00%> (-2.16%) ⬇️
mmdet/core/bbox/coder/yolo_bbox_coder.py 58.97% <0.00%> (-2.01%) ⬇️
mmdet/core/anchor/point_generator.py 51.57% <0.00%> (-1.96%) ⬇️
mmdet/datasets/pipelines/instaboost.py 13.55% <0.00%> (-1.45%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475c6be...920e23a. Read the comment docs.

@AronLin
Copy link
Contributor

AronLin commented Jul 18, 2021

There is something wrong about lint. Please refer to CONTRIBUTING.md and install the pre-commit to fix the code style.

@KainingYing
Copy link
Author

[INFO] Installing environment for https://github.com/jumanjihouse/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('C:\\Ruby30-x64\\bin\\gem.CMD', 'install', '--no-document', '--no-format-executable', 'fake_gem__-0.0.0.gem')
return code: 1
expected return code: 0
stdout: (none)
stderr:
    ERROR:  While executing gem ... (Gem::DependencyResolutionError)
        conflicting dependencies rubocop (>= 0.68.1) and rubocop (= 0.85.1)
      Activated rubocop-0.85.1
      which does not match conflicting dependency (>= 0.68.1)

      Conflicting dependency chains:
        fake_gem__ (= 0.0.0), 0.0.0 activated, depends on
        rubocop (= 0.85.1), 0.85.1 activated

      versus:
        fake_gem__ (= 0.0.0), 0.0.0 activated, depends on
        rubocop-rspec (= 1.40.0), 1.40.0 activated, depends on
        rubocop (>= 0.68.1)

      Gems matching rubocop (>= 0.68.1):
        rubocop-1.18.3

Check the log at C:\Users\Administrator.DESKTOP-EASJP9H\.cache\pre-commit\pre-commit.log

I use the pre-commit on win10. And I install the config into hook. When i use the git commit, this error occurs. how can I fix this problem?
many thanks!

@ZwwWayne
Copy link
Collaborator

[INFO] Installing environment for https://github.com/jumanjihouse/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('C:\\Ruby30-x64\\bin\\gem.CMD', 'install', '--no-document', '--no-format-executable', 'fake_gem__-0.0.0.gem')
return code: 1
expected return code: 0
stdout: (none)
stderr:
    ERROR:  While executing gem ... (Gem::DependencyResolutionError)
        conflicting dependencies rubocop (>= 0.68.1) and rubocop (= 0.85.1)
      Activated rubocop-0.85.1
      which does not match conflicting dependency (>= 0.68.1)

      Conflicting dependency chains:
        fake_gem__ (= 0.0.0), 0.0.0 activated, depends on
        rubocop (= 0.85.1), 0.85.1 activated

      versus:
        fake_gem__ (= 0.0.0), 0.0.0 activated, depends on
        rubocop-rspec (= 1.40.0), 1.40.0 activated, depends on
        rubocop (>= 0.68.1)

      Gems matching rubocop (>= 0.68.1):
        rubocop-1.18.3

Check the log at C:\Users\Administrator.DESKTOP-EASJP9H\.cache\pre-commit\pre-commit.log

I use the pre-commit on win10. And I install the config into hook. When i use the git commit, this error occurs. how can I fix this problem?
many thanks!

This is because the installation of ruby does not succeed. You might need to refer to this doc to install ruby, there is a section about it in the end. For windows environment, you might need fix more issue about it, you may try conda install -c conda-forge ruby first.
There are also two workarounds:

  1. Use markdown lint tool in your IDE, for example, VSCode support markdown lint tool and you can use it to modify it in your IDE.
  2. add '-n' in your command to skip the pre-commit hook and fix the issues in CI, which is not recommended as it waste the resources in CI.

@KainingYing
Copy link
Author

[INFO] Installing environment for https://github.com/jumanjihouse/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('C:\\Ruby30-x64\\bin\\gem.CMD', 'install', '--no-document', '--no-format-executable', 'fake_gem__-0.0.0.gem')
return code: 1
expected return code: 0
stdout: (none)
stderr:
    ERROR:  While executing gem ... (Gem::DependencyResolutionError)
        conflicting dependencies rubocop (>= 0.68.1) and rubocop (= 0.85.1)
      Activated rubocop-0.85.1
      which does not match conflicting dependency (>= 0.68.1)

      Conflicting dependency chains:
        fake_gem__ (= 0.0.0), 0.0.0 activated, depends on
        rubocop (= 0.85.1), 0.85.1 activated

      versus:
        fake_gem__ (= 0.0.0), 0.0.0 activated, depends on
        rubocop-rspec (= 1.40.0), 1.40.0 activated, depends on
        rubocop (>= 0.68.1)

      Gems matching rubocop (>= 0.68.1):
        rubocop-1.18.3

Check the log at C:\Users\Administrator.DESKTOP-EASJP9H\.cache\pre-commit\pre-commit.log

I use the pre-commit on win10. And I install the config into hook. When i use the git commit, this error occurs. how can I fix this problem?
many thanks!

This is because the installation of ruby does not succeed. You might need to refer to this doc to install ruby, there is a section about it in the end. For windows environment, you might need fix more issue about it, you may try conda install -c conda-forge ruby first.
There are also two workarounds:

  1. Use markdown lint tool in your IDE, for example, VSCode support markdown lint tool and you can use it to modify it in your IDE.
  2. add '-n' in your command to skip the pre-commit hook and fix the issues in CI, which is not recommended as it waste the resources in CI.

Thanks for your advice. I fix it degrade the ruby3 to ruby2.

Copy link
Contributor

@AronLin AronLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more details need to modify

docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
docs_zh-CN/2_new_data_model.md Outdated Show resolved Hide resolved
@KainingYing
Copy link
Author

Thanks for your patience review. You guys really makes my day. Appreciate it!

@ZwwWayne ZwwWayne merged commit f2b5999 into open-mmlab:master Jul 20, 2021
@KainingYing KainingYing deleted the cndocs branch July 20, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants