-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] add Chinese version of 2_new_data_model #5618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a space between Chinese and English, So, Please check your PR
…ors and statements have been modified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @noobying , thanks for the efforts. The overall PR looks great. Some tweaks need to be resolved to make it more smooth. I also suggest we read it again to make it more straightforward and easy to read.
Codecov Report
@@ Coverage Diff @@
## master #5618 +/- ##
==========================================
- Coverage 66.02% 65.63% -0.39%
==========================================
Files 279 279
Lines 21889 21740 -149
Branches 3629 3629
==========================================
- Hits 14452 14269 -183
- Misses 6675 6697 +22
- Partials 762 774 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There is something wrong about lint. Please refer to CONTRIBUTING.md and install the pre-commit to fix the code style. |
I use the pre-commit on win10. And I install the config into hook. When i use the |
This is because the installation of ruby does not succeed. You might need to refer to this doc to install ruby, there is a section about it in the end. For windows environment, you might need fix more issue about it, you may try
|
Thanks for your advice. I fix it degrade the ruby3 to ruby2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more details need to modify
Thanks for your patience review. You guys really makes my day. Appreciate it! |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
This PR adds Chinese version of 2_new_data_model
Modification
This PR adds Chinese version of 2_new_data_model