Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebase): support mmdet3d dev-1.x 1.1.0rc1 #1225

Merged

Conversation

tpoisonooo
Copy link
Collaborator

@tpoisonooo tpoisonooo commented Oct 19, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support mmdet3d dev-1.x branch and mmengine

  • pointpillars support trt, openvino and ort
  • centerpoint support trt, openvino and ort

Known issue:

Modification

  • update codebase/mmdet3d
  • update rewrite
  • rebase mmdeploy/dev-1.x branch

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon
Copy link
Collaborator

@tpoisonooo may need to fix ci TypeError: Can't instantiate abstract class Classification with abstract methods mode

@RunningLeon
Copy link
Collaborator

@tpoisonooo Could you update regression yaml for mmdet3d?

@tpoisonooo
Copy link
Collaborator Author

@tpoisonooo Could you update regression yaml for mmdet3d?

WIP.

@RunningLeon
Copy link
Collaborator

@tpoisonooo could fix ut of mmdet3d.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon
Copy link
Collaborator

@tpoisonooo TODO: Fix ut in another PR

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 331292a into open-mmlab:dev-1.x Nov 4, 2022
@tpoisonooo tpoisonooo deleted the fix-mmdet3d-1.x-rebase-faile branch November 8, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants