Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add the support of BoxIouRotated op for ascend device #2854

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

MrShadowY
Copy link
Contributor

@MrShadowY MrShadowY commented Jun 30, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add the support of BoxIouRotated op for ascend device

Modification

Add the support of BoxIouRotated op for ascend device

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

Tests
image
image
image
image

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2023

CLA assistant check
All committers have signed the CLA.

@momo609
Copy link
Collaborator

momo609 commented Jul 17, 2023

/lgtm

@MrShadowY MrShadowY changed the title Add the support of BoxIouRotated op for ascend device [Feature] Add the support of BoxIouRotated op for ascend device Jul 17, 2023
Copy link
Collaborator

@ckirchhoff2021 ckirchhoff2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@MrShadowY MrShadowY force-pushed the 0630 branch 2 times, most recently from 499905e to 9193254 Compare July 18, 2023 09:42
@zhouzaida zhouzaida merged commit 8fbacc4 into open-mmlab:1.x Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants