Add CropLike #299
Merged
Add CropLike #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 80.54% 80.65% +0.10%
==========================================
Files 162 162
Lines 8091 8110 +19
Branches 1192 1193 +1
==========================================
+ Hits 6517 6541 +24
+ Misses 1429 1425 -4
+ Partials 145 144 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
May 11, 2021
mmedit/datasets/pipelines/crop.py
Outdated
| Modify the size of image by cropping or padding. Align upper-left. | ||
|
|
||
| Args: | ||
| target_key (str): The target key. |
innerlee
reviewed
May 11, 2021
mmedit/datasets/pipelines/crop.py
Outdated
|
|
||
| The priority of getting 'target size' is: | ||
| 1, results[source_key].shape | ||
| 2, target_size |
There was a problem hiding this comment.
Add a note for the required, added and modified keys.
innerlee
reviewed
May 11, 2021
mmedit/datasets/pipelines/crop.py
Outdated
|
|
||
|
|
||
| @PIPELINES.register_module() | ||
| class ModifySize: |
There was a problem hiding this comment.
Random thought: how about rename it to "TopLeftCrop"?
added 2 commits
May 11, 2021 20:40
innerlee
reviewed
May 12, 2021
mmedit/datasets/pipelines/crop.py
Outdated
| @@ -1,5 +1,6 @@ | |||
| import mmcv | |||
| import numpy as np | |||
| from PIL.Image import NONE | |||
innerlee
reviewed
May 12, 2021
mmedit/datasets/pipelines/crop.py
Outdated
|
|
||
| @PIPELINES.register_module() | ||
| class CropLike: | ||
| """Crop/pad a key according to the size of another key. |
There was a problem hiding this comment.
Crop/pad the image in the target_key according to the size of image in the reference_key .
innerlee
approved these changes
May 12, 2021
innerlee
reviewed
May 12, 2021
| return results | ||
|
|
||
| def __repr__(self): | ||
| return (self.__class__.__name__ + f' target_key={self.target_key}, ' + |
There was a problem hiding this comment.
return (f'{self.__class__.__name__} target_key={self.target_key}, '
f'reference_key={self.reference_key}')
Yshuo-Li
added a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
* add ModifySize * Rename * Rename and fix * tiny fix Co-authored-by: liyinshuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.