Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeCamp2023-653] Add new configs of Real BasicVSR #2030

Merged
merged 2 commits into from
Sep 14, 2023
Merged

[CodeCamp2023-653] Add new configs of Real BasicVSR #2030

merged 2 commits into from
Sep 14, 2023

Conversation

RangeKing
Copy link
Contributor

Motivation

Add new configs of Real BasicVSR

Result

  • The output of config_validate.py
    config_validate_vsr

  • The output of test.py (only use the folder 000 of VideoLQ for test)
    config_validate_vsr_2

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head cc4ecb9 differs from pull request most recent head e6411f6. Consider uploading reports for the commit e6411f6 to get more accurate results

Files Changed Coverage
mmagic/apis/inferencers/base_mmagic_inferencer.py 0.00%

📢 Thoughts on this report? Let us know!.

@RangeKing RangeKing changed the title [CodeCamp2023-xxx] Add new configs of Real BasicVSR [CodeCamp2023-653] Add new configs of Real BasicVSR Sep 14, 2023
LeoXing1996
LeoXing1996 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeoXing1996 LeoXing1996 merged commit b9d39bf into open-mmlab:main Sep 14, 2023
7 checks passed
okotaku added a commit to okotaku/mmagic that referenced this pull request Sep 15, 2023
@okotaku
Revert "[CodeCamp2023-653] Add new configs of Real BasicVSR (open-mml…
d5767b7 
…ab#2030)"

This reverts commit b9d39bf.
@RangeKing RangeKing deleted the new_config_rbasicvsr branch September 16, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoXing1996 LeoXing1996 LeoXing1996 approved these changes

Assignees

@LeoXing1996 LeoXing1996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RangeKing @LeoXing1996