-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] AttentionRefine BUG & Add assets & TYPO in prompt-to-prompt project #2012
Conversation
…-to-prompt notebook demo
Hi @Beaconsyh08, We'd like to express our appreciation for your valuable contributions to the mmagic. Your efforts have significantly aided in enhancing the project's quality. If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID". Thanks again for your awesome contribution, and we're excited to have you as part of our community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Modification
1. ~/mmagic/projects/prompt_to_prompt/assets
In the demo notebook(~/mmagic/projects/prompt_to_prompt/visualize.ipynb), Part VAE vs DDIM Inversion vs Null-Text Inversion, Section 1. VAE reconstruction as the standard result. The code block loads the image path from [projects/prompt_to_prompt/assets/gnochi_mirror.jpeg]. However, the project doesn't contain the specific folder assets. Then, I download the gnochi_mirror image from prompt-to-prompt repository(https://github.com/google/prompt-to-prompt) and add it to the mmagic repository.
2. ~/mmagic/projects/prompt_to_prompt/models/seq_aligner.py
If you run the demo code in the above notebook, you will find that the AttentionRefine function doesn't work in the Section Prompt-to-prompt Editing. It shows
Hence, the function get_matrix in ~/mmagic/projects/prompt_to_prompt/models/seq_aligner.py should be modified to make the function work.
TYPO "1. VAE reconstruction as the a standard result" --> "1. VAE reconstruction as the standard result"
BC-breaking (Optional)
N/A
Use cases (Optional)
Checklist
Submitting this pull request means that,
Before PR:
After PR: