-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeCamp2023-648]MMagic 新 config 体验与适配 GuidedDiffusion #2005
[CodeCamp2023-648]MMagic 新 config 体验与适配 GuidedDiffusion #2005
Conversation
…nfigs_guided_diffusion
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 424 424
Lines 29109 29109
Branches 4502 4502
=======================================
Hits 23502 23502
Misses 4630 4630
Partials 977 977
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@LeoXing1996 may be it can be reviewed,I just updated it😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I only have one small modification requests.
Since PR #2007 is merged, you can remove those comments to skip flake8 checking.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
add new config for mmagic/guided_diffusion
output of the
config_validate.py
isTrue
output of Infer Instructions
the output inTest Instructions
python tools/test.py mmagic/configs/guided_diffusion/adm_ddim250_8xb32_imagenet_64x64.py https://download.openmmlab.com/mmgen/guided_diffusion/adm-u-cvt-rgb_8xb32_imagenet-64x64-7ff0080b.pth
it's show the
label
insample_kwargs
is none(inadm.py
), so i # it,actually ,the config isn't havelabel
and ouput is success!Modification
add
mmagic/configs/
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Submitting this pull request means that,
Before PR:
After PR: