Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taited/stable diffusion inpaint #1976

Merged
merged 9 commits into from
Aug 11, 2023

Conversation

Taited
Copy link
Contributor

@Taited Taited commented Aug 9, 2023

support stable diffusion inpainting config and pipeline

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 55.62% and project coverage change: -0.15% ⚠️

Comparison is base (66e4637) 80.87% compared to head (7361384) 80.73%.

❗ Current head 7361384 differs from pull request most recent head b61a21f. Consider uploading reports for the commit b61a21f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   80.87%   80.73%   -0.15%     
==========================================
  Files         423      424       +1     
  Lines       28952    29109     +157     
  Branches     4461     4502      +41     
==========================================
+ Hits        23416    23502      +86     
- Misses       4579     4630      +51     
- Partials      957      977      +20     
Flag Coverage Δ
unittests 80.73% <55.62%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...itors/stable_diffusion/stable_diffusion_inpaint.py 53.89% <53.89%> (ø)
mmagic/models/editors/__init__.py 100.00% <100.00%> (ø)
mmagic/models/editors/ddpm/denoising_unet.py 79.18% <100.00%> (+0.04%) ⬆️
mmagic/models/editors/stable_diffusion/__init__.py 100.00% <100.00%> (ø)
mmagic/models/editors/stable_diffusion/vae.py 87.24% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zengyh1900 zengyh1900 assigned zengyh1900 and unassigned liuwenran Aug 10, 2023
@zengyh1900 zengyh1900 self-requested a review August 10, 2023 07:07
@zengyh1900
Copy link
Collaborator

Hi @Taited ,
Since you are adding a new config in this pr, you need to mention this new config in the corresponding readme's table.
But don't worry, I have pushed a commit to fix the lint error.

@@ -0,0 +1,497 @@
# Copyright (c) OpenMMLab. All rights reserved.
from typing import Dict, List, Optional, Union
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this implementation seems heavily referred to other repo's implementation. Please mention their copyright here.

@@ -83,6 +84,40 @@ image = StableDiffuser.infer(prompt)['samples'][0]
image.save('robot.png')
```

To inpaint an image, you could run the following codes.

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```python

Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyh1900 zengyh1900 merged commit 0448b89 into open-mmlab:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants