Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support noise offset in stable diffusion training #1880

Merged
merged 3 commits into from
May 29, 2023

Conversation

LeoXing1996
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support noise offset introduced by https://www.crosslabs.org/blog/diffusion-with-offset-noise, which enables stable diffusion to generate lighter or darker images.

Modification

As title.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 self-assigned this May 29, 2023
@LeoXing1996 LeoXing1996 force-pushed the leoxing/add-noise-offset branch from 51f1096 to 06f116d Compare May 29, 2023 08:11
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (5f62dee) 83.00% compared to head (aa551a8) 83.00%.

❗ Current head aa551a8 differs from pull request most recent head bd370ca. Consider uploading reports for the commit bd370ca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   83.00%   83.00%   -0.01%     
==========================================
  Files         411      411              
  Lines       27603    27607       +4     
  Branches     4316     4317       +1     
==========================================
+ Hits        22913    22915       +2     
- Misses       3754     3756       +2     
  Partials      936      936              
Flag Coverage Δ
unittests 83.00% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmagic/models/editors/controlnet/controlnet.py 50.17% <ø> (ø)
mmagic/models/editors/dreambooth/dreambooth.py 63.75% <ø> (ø)
...odels/editors/stable_diffusion/stable_diffusion.py 59.16% <50.00%> (-0.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoXing1996 LeoXing1996 requested a review from Z-Fran May 29, 2023 10:41
@LeoXing1996 LeoXing1996 merged commit 3c5bd83 into open-mmlab:main May 29, 2023
@LeoXing1996 LeoXing1996 deleted the leoxing/add-noise-offset branch May 29, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants