-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] register models and scheduelrs from diffusers #1692
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #1692 +/- ##
===========================================
- Coverage 88.15% 88.14% -0.01%
===========================================
Files 399 399
Lines 26372 26410 +38
Branches 4114 4122 +8
===========================================
+ Hits 23247 23278 +31
- Misses 2241 2245 +4
- Partials 884 887 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we didn't support pipelines. How about wrapping pipelines into Inferencer?
As for training, I support implementing it in |
The pipelines in diffusers are actually a set of models and process steps, which may be similar to |
Yes. We will support training in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Diffusers
+ the class name.Modification
After register, the models and schedulers from diffusers can be used as below.
Schedulers
DDPMScheduler
throughmmedit.registry
torch.tensor
and sample noiseModels
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: