Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add tools/analysis_tools/print_config.py #1590

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

i-aki-y
Copy link
Contributor

@i-aki-y i-aki-y commented Jan 9, 2023

Add a print_config.py into 1.x branch

Motivation

close #1535

Modification

Add a new script tools/misc/print_config.py
The code was borrowed from the other open-mmlab project.
ex. https://github.com/open-mmlab/mmclassification/blob/1.x/tools/misc/print_config.py

BC-breaking (Optional)

This works in 1.x branch and does not in < 1.x because the Config and DictAction are imported from the mmengine instead of mmcv.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

@i-aki-y i-aki-y changed the title Add tools/misc/print_config.py [Feature] Add tools/misc/print_config.py Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 87.92% // Head: 87.92% // No change to project coverage 👍

Coverage data is based on head (5f89133) compared to base (8b30739).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1590   +/-   ##
========================================
  Coverage    87.92%   87.92%           
========================================
  Files          399      399           
  Lines        26051    26051           
  Branches      4048     4048           
========================================
  Hits         22906    22906           
  Misses        2240     2240           
  Partials       905      905           
Flag Coverage Δ
unittests 87.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

LeoXing1996
LeoXing1996 previously approved these changes Jan 11, 2023
@Z-Fran
Copy link
Collaborator

Z-Fran commented Jan 13, 2023

Please move this file to the folder tools/analysis_tools @i-aki-y

@i-aki-y i-aki-y changed the title [Feature] Add tools/misc/print_config.py [Feature] Add tools/analysis_tools/print_config.py Jan 13, 2023
@i-aki-y
Copy link
Contributor Author

i-aki-y commented Jan 13, 2023

@Z-Fran Thank you for your review
I moved the file.

@Z-Fran Z-Fran merged commit 328c875 into open-mmlab:dev-1.x Jan 17, 2023
@Z-Fran Z-Fran linked an issue Jan 17, 2023 that may be closed by this pull request
@Z-Fran
Copy link
Collaborator

Z-Fran commented Jan 17, 2023

Thanks for your contribution. @i-aki-y

@Z-Fran Z-Fran mentioned this pull request Mar 2, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Print full config not exists
4 participants