Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix restormer ut #1550

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[Fix] fix restormer ut #1550

merged 1 commit into from
Dec 22, 2022

Conversation

Z-Fran
Copy link
Collaborator

@Z-Fran Z-Fran commented Dec 22, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Ut failed on torch<1.8

Modification

Skip restormer ut on torch<1.8

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran self-assigned this Dec 22, 2022
@Z-Fran Z-Fran added the kind/bug something isn't working label Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 88.11% // Head: 88.11% // No change to project coverage 👍

Coverage data is based on head (72aa051) compared to base (b13cd06).
Patch has no changes to coverable lines.

❗ Current head 72aa051 differs from pull request most recent head b68c5c5. Consider uploading reports for the commit b68c5c5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1550   +/-   ##
========================================
  Coverage    88.11%   88.11%           
========================================
  Files          386      386           
  Lines        24442    24442           
  Branches      3820     3820           
========================================
  Hits         21537    21537           
  Misses        2085     2085           
  Partials       820      820           
Flag Coverage Δ
unittests 88.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran requested a review from LeoXing1996 December 22, 2022 09:44
@Z-Fran Z-Fran merged commit 11f5c2e into open-mmlab:dev-1.x Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants