Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Update version file #136

Merged
merged 5 commits into from
Sep 19, 2020
Merged

Conversation

nbei
Copy link
Collaborator

@nbei nbei commented Sep 17, 2020

No description provided.

@nbei nbei requested a review from hellock September 17, 2020 16:37
@nbei nbei requested review from hejm37 and removed request for hellock September 17, 2020 16:50
@nbei nbei requested review from hellock and removed request for hejm37 September 17, 2020 17:02
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #136 into master will decrease coverage by 0.07%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   82.32%   82.25%   -0.08%     
==========================================
  Files         143      144       +1     
  Lines        6621     6651      +30     
  Branches      986      992       +6     
==========================================
+ Hits         5451     5471      +20     
- Misses       1071     1079       +8     
- Partials       99      101       +2     
Flag Coverage Δ
#unittests 82.25% <67.74%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/version.py 58.33% <58.33%> (ø)
mmedit/__init__.py 73.68% <73.68%> (-26.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7253ba8...41a5ed5. Read the comment docs.

.gitignore Outdated
@@ -105,7 +105,7 @@ venv.bak/
.mypy_cache/

# custom
mmedit/version.py
# mmedit/version.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove this line

from .version import __version__, version_info

MMCV_MIN = '1.0.2'
MMCV_MAX = '1.2.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2

@@ -54,26 +53,6 @@ def get_hash():
return sha
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the get_hash and get_git_hash are no longer used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this func may be called by extra repo. ^_^

@hellock hellock merged commit afea45a into open-mmlab:master Sep 19, 2020
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants