Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support repeat_aug #2170

Merged
merged 5 commits into from
Jan 10, 2023
Merged

[Feature] support repeat_aug #2170

merged 5 commits into from
Jan 10, 2023

Conversation

hukkai
Copy link
Collaborator

@hukkai hukkai commented Jan 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@ly015 ly015 changed the title support repeat_aug [Feature] support repeat_aug Jan 10, 2023
modality: str = 'RGB',
**kwargs) -> None:

flag = get_type(pipeline[0]) == 'DecordInit' and \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid using ambiguous variable names like flag. What about backend_supported?

@ly015 ly015 merged commit 1405434 into open-mmlab:dev-1.x Jan 10, 2023
ly015 pushed a commit that referenced this pull request Jan 10, 2023
@hukkai hukkai deleted the repeat_aug branch June 15, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants