Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mlu): Support MLU Backend #1608

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

zgplvyou
Copy link
Contributor

@zgplvyou zgplvyou commented Apr 26, 2022

Support Cambricon MLU device for MMaction2.

Motivation

Support Cambricon MLU device for MMaction2.

Modification

mmaction/apis/train.py : train on the default device.
tools/test.py : test on the default device.
mmaction/utils/distribution_env.py : choose the default device; build ddp and dp model.

BC-breaking (Optional)

No BC-breaking

Use cases (Optional)

you can use the native script of gpu devices to train the model on mlu devices without any change.

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2022

CLA assistant check
All committers have signed the CLA.

@kennymckormick
Copy link
Member

@zgplvyou , please help fix the lint problem

@zgplvyou
Copy link
Contributor Author

train on mlu:
{02e87d3e-5a0d-4f8e-b876-228757deb36d}

@zgplvyou
Copy link
Contributor Author

zgplvyou commented Apr 28, 2022

pytest tests/
{1112c58e-9b7b-4217-a220-b3104451309c}
we got the result of 1 failed, 213 passed, 5 skipped, 333 warnings. and on the master branch, we got the same result.

@zgplvyou
Copy link
Contributor Author

code coverage:
{f008a0fd-3370-40ea-aa4c-6b0bd1f58a41}
we got the same percent(85%) code coverage as master. And we need run the tests on mlu device to cover the file of "mmaction/utils/distribution_env.py".

@HarryZJ
Copy link

HarryZJ commented Apr 28, 2022

pytest tests/ {1112c58e-9b7b-4217-a220-b3104451309c} we got the result of 1 failed, 213 passed, 5 skipped, 333 warnings. and on the master branch, we got the same result.

@kennymckormick it seems like the test_rawframe_decode requires libturbojpeg library, but we didn't installed it in our system. That's how i guess.

@kennymckormick
Copy link
Member

LGTM, is it OK to merge this PR now?

@HarryZJ
Copy link

HarryZJ commented Apr 28, 2022

LGTM

@kennymckormick kennymckormick merged commit 5e853b1 into open-mmlab:master Apr 29, 2022
@OpenMMLab-Assistant-004
Copy link

Hi @zgplvyou !First of all, we want to express our gratitude for your significant PR in the mmaction2 project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants