Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-test): segmentation fault error unit tests #7840

Merged
merged 6 commits into from
Oct 13, 2022
Merged

fix(ui-test): segmentation fault error unit tests #7840

merged 6 commits into from
Oct 13, 2022

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes :

I worked on the fixing segmentation fault error

Getting segmentation fault error on GitHub CI too frequently for running tests with coverage. trying possible fix for it
Reference: jestjs/jest#10662

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@chirag-madlani
fix(ui-test): segmentation fault error unit tests
d612d87 
Getting segmentation fault error on GitHub CI too frequently for running tests with coverage. trying possible fix for it 
Reference: jestjs/jest#10662
@chirag-madlani chirag-madlani requested a review from a team as a code owner October 1, 2022 09:15
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 09:15 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 09:15 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 09:15 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 09:15 Inactive
@cypress
Copy link

cypress bot commented Oct 1, 2022 •
edited
Loading


Test summary

149 • 0 • 3 • 0

Run details
Project openmetadata
Status Passed
Commit 11ae48f
Started Oct 13, 2022 1:50 PM
Ended Oct 13, 2022 2:14 PM
Duration 23:56 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 11:46 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 11:46 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 11:46 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 1, 2022 11:46 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 12, 2022 10:58 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 12, 2022 10:58 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 12, 2022 10:58 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 12, 2022 10:58 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 10:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 10:32 Inactive
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 13:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 13:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 13:32 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress October 13, 2022 13:32 Inactive
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

17.0% 17.0% Coverage
0.0% 0.0% Duplication

ShaileshParmar11
ShaileshParmar11 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😊

@Sachin-chaurasiya Sachin-chaurasiya merged commit 2349684 into main Oct 13, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the fix-segmentation-fault branch October 13, 2022 14:24
chirag-madlani added a commit that referenced this pull request Nov 18, 2022
@chirag-madlani
fix(ui-test): segmentation fault error unit tests (#7840)
5663b0d 
* fix(ui-test): segmentation fault error unit tests

Getting segmentation fault error on GitHub CI too frequently for running tests with coverage. trying possible fix for it
Reference: jestjs/jest#10662

* fix failed unit tests

* remove coverage to test segmentation fault

* update maxWorker to resolve segmentation fault

* remove duplicate key from props

(cherry picked from commit 2349684)
mohityadav766 added a commit that referenced this pull request Nov 18, 2022
@mohityadav766 @chirag-madlani
Release 0.12.3 - Updated the required files (#8879)
4f2d7fe 
* Release 0.12.3 - Updated the required files

* updated Docker File

* fix(ui-test): segmentation fault error unit tests (#7840)

* fix(ui-test): segmentation fault error unit tests

Getting segmentation fault error on GitHub CI too frequently for running tests with coverage. trying possible fix for it
Reference: jestjs/jest#10662

* fix failed unit tests

* remove coverage to test segmentation fault

* update maxWorker to resolve segmentation fault

* remove duplicate key from props

(cherry picked from commit 2349684)

Co-authored-by: Chirag Madlani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirag-madlani @Sachin-chaurasiya @ShaileshParmar11