Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide Incremental Metadata Extraction config for unsupported database sources #19468

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shrushti2000
Copy link
Contributor

@shrushti2000 shrushti2000 commented Jan 21, 2025

Fixes #17397

Currently, the Incremental Metadata Extraction configuration is displayed for all database sources, even though it is only supported by RedShift, BigQuery, and Snowflake.
This PR updates the application logic to hide the Incremental Metadata Extraction config for all database sources other than RedShift, BigQuery, and Snowflake.

Displaying Incremental Metadata Extraction for BigQuery

Screen.Recording.2025-01-23.at.8.07.42.PM.1.1.mov

Hiding Incremental Metadata Extraction for all other dbs.

Screen.Recording.2025-01-23.at.8.14.30.PM.1.1.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@shrushti2000 shrushti2000 changed the title Fix: Hide Incremental Metadata Extraction for unsupported database sources Fix: Hide Incremental Metadata Extraction config for unsupported database sources Jan 21, 2025
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@shrushti2000 shrushti2000 marked this pull request as ready for review January 23, 2025 14:55
@shrushti2000 shrushti2000 requested a review from a team as a code owner January 23, 2025 14:55
@shrushti2000 shrushti2000 changed the title Fix: Hide Incremental Metadata Extraction config for unsupported database sources Fix: Handle Incremental Metadata Extraction config for unsupported database sources Jan 23, 2025
@shrushti2000 shrushti2000 changed the title Fix: Handle Incremental Metadata Extraction config for unsupported database sources Fix: Hide Incremental Metadata Extraction config for unsupported database sources Jan 23, 2025
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.52% (40594/62919) 40.76% (16266/39907) 43.86% (4914/11205)

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental Metadata Extraction is dispalyed for sources that are not supported
4 participants