Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) fix retention period 'Cancel' international display issue #19404

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(ui) fix retention period 'Cancel' international display issue #19404

merged 2 commits into from
Jan 24, 2025

Conversation

sdhzwc
Copy link
Contributor

@sdhzwc sdhzwc commented Jan 16, 2025 •
edited
Loading

Describe your changes:

Fixes #19403

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sdhzwc sdhzwc requested a review from a team as a code owner January 16, 2025 10:24
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@Ashish8689 Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (40893/63277) 40.68% (16356/40208) 44.09% (4970/11272)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 0342914 into open-metadata:main Jan 24, 2025
15 of 17 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
@sdhzwc
fix(ui) fix retention period 'Cancel' international display issue (#1…
edc66ea 
…9404)

Co-authored-by: Ashish Gupta <[email protected]>
(cherry picked from commit 0342914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashish8689 Ashish8689 Ashish8689 approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retention period international display issue
2 participants
@sdhzwc @Ashish8689