Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #65: Provide optional argument for install to skip DB installation #66

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

Dagefoerde
Copy link
Contributor

@Dagefoerde Dagefoerde commented Oct 23, 2017

This adds the option to pass --skip-db-install to the install command, causing the InstallerFactory to omit core/plugin installation.

Sorry, I have no idea on how to test this properly, given that I'd need to test the absence of an installed DB... If you have any idea, feel free to suggest / add to this branch.

Either way, the existing workflow is not broken, as confirmed by your existing tests.

Cheers!

@polothy polothy merged commit fa585b7 into open-lms-open-source:master Nov 3, 2017
@polothy
Copy link
Contributor

polothy commented Nov 3, 2017

Thanks! Ended up renaming the option to --no-init

@polothy
Copy link
Contributor

polothy commented Nov 3, 2017

If you want to try it out, you can use: - composer create-project -n --no-dev --prefer-dist moodlerooms/moodle-plugin-ci ci dev-master but remember to switch it back later.

@Dagefoerde
Copy link
Contributor Author

@mrmark thanks for the hint, will try next time! :)
(Also, many thanks for incorporating this! This should speed up our initial stage.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants