Add max-warnings to codechecker and grunt eslint #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2020
marinaglancy
pushed a commit
to moodleworkplace/moodle-plugin-ci
that referenced
this pull request
Jun 15, 2020
Note that these changes, and also the previous open-lms-open-source#111 are for nothing unless packagist is refreshed with a new release of moodle-plugin-ci. Without that everybody continues getting old outdated, components, like local_codechecker 2.9.3, for example, that is the one corresponding to the latest version (2.5.0) released @ packagist of moodle-plugin-ci. Current one is really aging (Feb 2019)! Link: https://packagist.org/packages/blackboard-open-source/moodle-plugin-ci And only solution for developers is to use custom repositories and other non-ideal tricks to get the actual versions installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be more strict with the checks and fail on both code and eslint warnings. Therefore I propose the max-warning options.
Add option
moodle-plugin-ci codechecker --max-warnings 0, this means that codechecker will return non-zero status if there are any warnings, even when there are no errors.Add option
moodle-plugin-ci grunt --max-lint-warnings 0, this is the same setting as you can pass togruntitself added in https://tracker.moodle.org/browse/MDL-68323 . It is already integrated and will be available in 3.7.6, 3.8.3 and above. This will tell grunt to fail if there are any eslint warnings.Add option
moodle-plugin-ci grunt --show-lint-warnings, again, the same setting as you can pass togruntin moodle, this already existed in moodle. It shows eslint warnings but does not fail if there are warnings, only fails on errors.This PR should replace #89 because the approach there was incorrect (and I can't do anything to that PR because I did not create it)
Additionally this PR contains a local_codechecker version bump to 2.9.5, this can replace #105