Issue open-horizon#4108 - Feature Request: Fail on agent-install.sh f…

[LiilyZhang]

…or k8s agent if storage class is invalid

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings
• I have tagged the reviewers in a comment below incase my pull request is ready for a review
• I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

[dlarson04]

Can you check this log_fatal message to

log_fatal 2 "storage class $storage_class does not exist in the edge cluster"

Currently it fails with

2024-07-18 14:26:10 KUBECTL is set to oc
2024-07-18 14:26:10 EDGE_CLUSTER_STORAGE_CLASS: fred (from environment variable)
2024-07-18 14:26:10 ERROR: fred does not exist in the edge cluster

I guess it is a little obvious that it is checking for the storage class but this would make it very clear