Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add maintainers.md #3

Merged
merged 1 commit into from
Oct 15, 2022
Merged

feat: add maintainers.md #3

merged 1 commit into from
Oct 15, 2022

Conversation

retry19
Copy link
Contributor

@retry19 retry19 commented Oct 15, 2022

Closes #2

New Changes

  • Added MAINTAINERS.md file

joewxboy
joewxboy requested changes Oct 15, 2022
View reviewed changes
Copy link
Member

@joewxboy joewxboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @retry19 , it looks like the file was created properly. However, you did not "sign" your commit. Could you please go back and amend your commit to add the sign-off?

@retry19
Copy link
Contributor Author

retry19 commented Oct 15, 2022

Thanks, @retry19 , it looks like the file was created properly. However, you did not "sign" your commit. Could you please go back and amend your commit to add the sign-off?

I wasn't aware of it, wait ya, fixing...

@retry19 retry19 force-pushed the feature/add-maintainers-md branch from 609ff91 to bc47ea1 Compare October 15, 2022 15:43
@retry19 retry19 requested a review from joewxboy October 15, 2022 15:46
@retry19
Copy link
Contributor Author

retry19 commented Oct 15, 2022

@joewxboy I already sign my commit

@retry19
feat: add maintainers.md
94d4999 
Signed-off-by: Reza Rachmanuddin <[email protected]>
@retry19 retry19 force-pushed the feature/add-maintainers-md branch from bc47ea1 to 94d4999 Compare October 15, 2022 15:49
@joewxboy joewxboy merged commit 2c952ef into open-horizon-services:main Oct 15, 2022
@joewxboy
Copy link
Member

Congratulations, Reza. You are now officially a project Contributor.

@retry19
Copy link
Contributor Author

retry19 commented Oct 15, 2022

Congratulations, Reza. You are now officially a project Contributor.

Thanks @joewxboy 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewxboy joewxboy joewxboy approved these changes

Assignees
No one assigned
Labels
hacktoberfest-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MAINTAINERS.md file
2 participants
@retry19 @joewxboy