Fix uwsgi crash on startup #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OIDC cache is obsolete, but there are still migrations pointing to it, so instead we can point it to the solo cache instead.
An attempt to fix the xmlsec version error, to no avail, but being on the latest patch *shouldn't* be a problem. Validated locally with docker-compose that it at least properly starts up.
The package is required when building lxml/xmlsec from source, but as of the latest releases, binary wheels can be installed. However, if this package is installed while uwsgi is being built/installed, this causes version mismatch problems. See xmlsec/python-xmlsec#320
Follow up from the Dockerfile patch before - this should be sufficient to install dependencies on CI with binary wheels, while keeping the package layout a bit closer to the Dockerfile.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4415 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 719 719
Lines 23688 23689 +1
Branches 2799 2799
=======================================
+ Hits 22858 22859 +1
Misses 562 562
Partials 268 268 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that our test env was down after the lxml/xmlsec upgrade and stumbled on xmlsec/python-xmlsec#320 as the same issue.
The fix is not to downgrade the libraries, but instead manage the environment in which uwsgi is being built better.