feat!: Add ProviderState #46
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
fatal-state
branch
from
8ae1b86
to
5b69522
Compare
fabriziodemaria
commented
Sep 4, 2024
Comment on lines
-98
to
-104
| let stateObserver = provider.observe().sink { | ||
| if $0 == .ready || $0 == .error { | ||
| continuation.resume() | ||
| holder.removeAll() | ||
| } | ||
| } | ||
| stateObserver.store(in: &holder) |
There was a problem hiding this comment.
I think this is a very good change
Signed-off-by: Fabrizio Demaria <[email protected]>
fix: setProvider sends Ready Event on success Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
commented
Sep 5, 2024
Comment on lines
-5
to
-8
| private let eventState: CurrentValueSubject<ProviderEvent, Never> | ||
| private let lastSentEvent = PassthroughSubject<ProviderEvent?, Never>() | ||
|
|
||
| convenience init() { | ||
| self.init(.notReady) |
There was a problem hiding this comment.
The EventHandler doesn't keep a "state" anymore, that is now responsibility of OpenFeatureAPI
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
fatal-state
branch
from
dee8973
to
203e8da
Compare
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
fatal-state
branch
from
203e8da
to
40d0812
Compare
fabriziodemaria
commented
Sep 6, 2024
fabriziodemaria
commented
Sep 6, 2024
Comment on lines
+10
to
+11
| /// It is expected that the implementer is slow and blocking (e.g. network), the caller must deal with wrapping this into a background Task if necessary | ||
| func initialize(initialContext: EvaluationContext?) throws |
There was a problem hiding this comment.
I think we need docs like this for user-facing setContext and setContextAndWait, as well, so it's clear that the former can take time and should be called from the UI thread.
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
fatal-state
branch
from
cabfae2
to
533f1ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Breaking Changes
initialize()implementation needs to throw in case of errors, rather than emitting theERRORevent. The latter is now responsibility of the SDK. This might apply to other parts of the integration as well (e.g. onContextChange)ERRORemission from the Provider side)Improvements