Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NOT_READY after provider shutdown #216

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Nov 15, 2023

Add requirement clarifying providers requiring initialization return to NOT_READY after shutdown, as agreed on here.

Fixes: #213

Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left this comment, otherwise change looks fine.

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@toddbaert
Copy link
Member Author

I'm going to merge this Friday EOD unless anyone has concerns.

@beeme1mr beeme1mr merged commit 73922b2 into main Nov 28, 2023
6 checks passed
@beeme1mr beeme1mr deleted the feat/shutdown-to-not-ready branch November 28, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify provider state after shutdown()
5 participants