feat: NOT_READY after provider shutdown #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
justinabrahms,
moredip,
federicobond,
dabeeeenster,
markphelps,
beeme1mr,
davejohnston,
thisthat,
jonathannorris,
nicklasl,
josecolella,
benjiro,
bacherfl,
thiyagu06,
kinyoklion,
lopitz,
Billlynch,
fabriziodemaria,
Kavindu-Dodan,
tcarrio,
thomaspoignant,
craigpastro,
lukas-reining,
james-milligan,
liran2000 and
rgrassian-split
toddbaert
force-pushed
the
feat/shutdown-to-not-ready
branch
from
37a35df
to
f224969
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Nov 15, 2023
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Nov 15, 2023
Kavindu-Dodan
approved these changes
Nov 15, 2023
beeme1mr
reviewed
Nov 15, 2023
toddbaert
commented
Nov 15, 2023
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Nov 20, 2023
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Nov 20, 2023
Signed-off-by: Todd Baert <[email protected]>
|
I'm going to merge this Friday EOD unless anyone has concerns. |
weyert
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add requirement clarifying providers requiring initialization return to
NOT_READYafter shutdown, as agreed on here.Fixes: #213