feat: add events #182
Merged
feat: add events #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
moredip,
thomaspoignant,
beeme1mr,
justinabrahms,
weyert,
dabeeeenster,
cdonnellytx,
davejohnston,
thisthat,
agentgonzo,
benjiro,
bacherfl,
thiyagu06,
kinyoklion,
hlipsig,
Kavindu-Dodan,
tcarrio,
InTheCloudDan,
matthewelwell,
ajhelsby,
skyerus,
lukas-reining,
james-milligan and
jakedoublev
and removed request for
moredip and
thomaspoignant
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
May 9, 2023
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
May 9, 2023
Kavindu-Dodan
approved these changes
May 9, 2023
There was a problem hiding this comment.
I think I'm convince on the completeness of this addition. Left one more concern about client shutdown [1] , but the rest looks good. Thank you @toddbaert for taking time on explaining core concepts and clearing doubts
[1] - #182 (comment)
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
reviewed
May 12, 2023
tcarrio
reviewed
May 12, 2023
kinyoklion
approved these changes
May 12, 2023
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
lukas-reining
approved these changes
May 12, 2023
Signed-off-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds events discussed in DRAFT client PR, and OFEPs.
Be sure to review
specification.jsonfor the net changes.Most of this is implemented in the web-sdk already. Some conforming (demo) providers can be found in the playground: