Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFEP-007: Surfacing flag metadata #169

Merged
merged 11 commits into from
Jan 23, 2023
Merged

OFEP-007: Surfacing flag metadata #169

merged 11 commits into from
Jan 23, 2023

Conversation

moredip
Copy link
Member

@moredip moredip commented Dec 19, 2022

  • add a flag metadata field to Evaluation Details and Resolution Details
  • ask the provider to provide it in Resolution Details
  • require the SDK to expose it to Evaluation Details

(co-authored with @justinabrahms)

- add a `flag metadata` field to Evaluation Details and Resolution Details
- ask the provider to provide it in Resolution Details
- require the SDK to expose it to Evaluation Details

Signed-off-by: Pete Hodgson <[email protected]>
Signed-off-by: Pete Hodgson <[email protected]>
@beeme1mr beeme1mr requested review from beeme1mr, a team and justinabrahms December 19, 2022 23:14
@beeme1mr
Copy link
Member

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to add this to the spec without changing the IDs of existing requirements? Requirement 1.4.7 would be 1.4.9 if your PR is merged as is. It would be great to avoid that if possible. If it's not, we'll have to clearly communicate the change during a spec release.

specification/sections/01-flag-evaluation.md Outdated Show resolved Hide resolved
@moredip moredip changed the title Pete/provider metadata OFEP-007: Surfacing flag metadata Dec 20, 2022
specification/types.md Outdated Show resolved Hide resolved
@beeme1mr
Copy link
Member

beeme1mr commented Jan 3, 2023

Hi @moredip, please address the feedback when you have a moment. Thanks!

Signed-off-by: Pete Hodgson <[email protected]>
Signed-off-by: Pete Hodgson <[email protected]>
@moredip
Copy link
Member Author

moredip commented Jan 11, 2023

Hi @moredip, please address the feedback when you have a moment. Thanks!

Sorry this took so long for me to get to. All feedback is addressed now I believe

Signed-off-by: Pete Hodgson <[email protected]>
@beeme1mr beeme1mr requested review from a team January 12, 2023 20:05
specification.json Outdated Show resolved Hide resolved
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Pete Hodgson <[email protected]>
specification/types.md Outdated Show resolved Hide resolved
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Pete Hodgson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants