-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release APIs and Operator independently #541
feat: release APIs and Operator independently #541
Conversation
Signed-off-by: Giovanni Liva <[email protected]>
track API package release independently
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
add debug info
Signed-off-by: Giovanni Liva <[email protected]>
track API package release independently
Signed-off-by: Giovanni Liva <[email protected]>
b3d0d1b
to
2b530e4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
- Coverage 82.81% 77.94% -4.88%
==========================================
Files 24 10 -14
Lines 1437 1020 -417
==========================================
- Hits 1190 795 -395
+ Misses 209 189 -20
+ Partials 38 36 -2 see 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -1,3 +1,4 @@ | |||
{ | |||
".": "0.2.36" | |||
".": "0.2.36", | |||
"apis": "0.2.36" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should decide what should be the first version of the APIs package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think same version as the current package makes sense...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will slightly change how the release process works. @toddbaert and I have dealt with this enough times that it shouldn't be an issue here.
Signed-off-by: Giovanni Liva <[email protected]>
"exclude-paths": [ | ||
"apis" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know this was an option.
I'm 100% on board with this. |
Nice, then I'll work on this PR making it fully working ;) |
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
To continue with this PR, I would need a tag for the |
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
You can see the tags created in my fork here: https://github.com/thisthat/open-feature-operator/tags
For the Operator, the release works as previously creating containers and publishing them to a registry: https://github.com/thisthat/open-feature-operator/actions/runs/6861654249
For the APIs, only a tag is created: https://github.com/thisthat/open-feature-operator/actions/runs/6861600403
This PR covers only the release process. We should also move all go files into two different go modules.
This entails the following:
go.mod
file under theapis
folderutils
in the newapis
pkg (it is used inalpha1
andalpha2
)