feat!: improve generic type accuracy #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 10 10
Lines 701 704 +3
Branches 84 84
=======================================
+ Hits 699 702 +3
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
reviewed
Sep 19, 2022
toddbaert
force-pushed
the
feat/more-accurate-generics
branch
from
e03999f
to
bea3d9f
Compare
|
rebased on main b/c of conflicts. |
beeme1mr
approved these changes
Sep 19, 2022
kinyoklion
approved these changes
Sep 19, 2022
beeme1mr
reviewed
Sep 20, 2022
beeme1mr
approved these changes
Sep 20, 2022
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/more-accurate-generics
branch
from
715d9a9
to
b72e8ee
Compare
This was referenced Sep 20, 2022
toddbaert
pushed a commit
that referenced
this pull request
Sep 20, 2022
🤖 I have created a release *beep* *boop* --- ## [0.4.0](js-sdk-v0.3.2...js-sdk-v0.4.0) (2022-09-20) ### ⚠ BREAKING CHANGES * improve generic type accuracy (#224) * convert to chainable methods (#221) * remove flag evaluation options from the provider interface (#185) * context transformer and related interfaces removed. ### Features * add client context mutation ([#207](#207)) ([5b0442a](5b0442a)) * add logger ([#219](#219)) ([763f167](763f167)) * convert to chainable methods ([#221](#221)) ([5253ad9](5253ad9)) * improve generic type accuracy ([#224](#224)) ([12230a5](12230a5)) * remove ctx transformer, add provider hooks ([#148](#148)) ([260432c](260432c)) * remove flag evaluation options from the provider interface ([#185](#185)) ([e9852e4](e9852e4)), closes [#183](#183) ### Bug Fixes * Add no-op tests ([#99](#99)) ([a341f5c](a341f5c)) * Dont push experiemental branches ([#101](#101)) ([0a7a5ec](0a7a5ec)) * Fix publish command ([#103](#103)) ([4742ef1](4742ef1)) * Fixing error with setProvider type ([#121](#121)) ([df5d214](df5d214)) * update the client to conform to the provider interface ([#187](#187)) ([f1edb29](f1edb29)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 7, 2022
lukas-reining
pushed a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tis nowT extends JsonValue)