Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental web support #200

Merged
merged 2 commits into from
Sep 29, 2022
Merged

feat: experimental web support #200

merged 2 commits into from
Sep 29, 2022

Conversation

toddbaert
Copy link
Member

Signed-off-by: Todd Baert [email protected]

@toddbaert toddbaert marked this pull request as draft September 1, 2022 12:57
@toddbaert
Copy link
Member Author

/publish

@toddbaert toddbaert changed the title wip feat: support web Sep 1, 2022
@beeme1mr beeme1mr self-requested a review September 15, 2022 21:34
@beeme1mr beeme1mr marked this pull request as ready for review September 15, 2022 21:34
@toddbaert toddbaert marked this pull request as draft September 19, 2022 20:24
package.json Outdated Show resolved Hide resolved
@toddbaert toddbaert force-pushed the feat/web branch 3 times, most recently from 3a8750d to 31c1179 Compare September 23, 2022 17:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #200 (990a549) into main (ce7c4ad) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          14       14           
  Lines        1099     1099           
  Branches       88       88           
=======================================
  Hits         1097     1097           
  Misses          2        2           
Impacted Files Coverage Δ
src/open-feature.ts 97.59% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert changed the title feat: support web feat: experimental web support Sep 23, 2022
@toddbaert
Copy link
Member Author

/publish

@toddbaert
Copy link
Member Author

@james-milligan I've published another experimental version. It shouldn't have any breaking changes, but if you could confirm next week that it works as expected with your web provider, I'd appreciate it!

@openfeature/js-sdk@0.4.0-experimental-e9ba70956ed77c7b41032b149a8f6bf915ae50e4

@agentgonzo
Copy link
Member

@toddbaert . I'm looking at a browser wrapper for CloudBees. I'll see if I can get it to work with this experimental version (I couldn't get it to work with the previous release)

@james-milligan
Copy link

@toddbaert i have this version working with the experimental version of the web provider

@agentgonzo
Copy link
Member

agentgonzo commented Sep 26, 2022

I have a fully working web application using the cloudbees feature provider and this experimental release 🎉
screen-recording

(Note: the backend events are still using our proprietary SDK to push updates through to the client, but all flag evaluation is done via the OpenFeature SDK)

@beeme1mr beeme1mr merged commit fd144bb into main Sep 29, 2022
@beeme1mr beeme1mr deleted the feat/web branch September 29, 2022 17:22
toddbaert pushed a commit that referenced this pull request Oct 3, 2022
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](js-sdk-v0.4.0...js-sdk-v0.5.0)
(2022-10-03)

This release makes some change to `errors` and `reasons`. Errors are now
an enumeration, and reasons are a free-form string. The
`EvaluationDetails` and `ResolutionDetails` structures also now include
an optional `errorMessage` which, in the case of abnormal execution,
corresponds to the `message` property of an underlying error that might
have occurred during flag evaluation.

This release also included **experimental** web support and
**experimental** transaction context propagation.

### ⚠ BREAKING CHANGES

* errorCode as enum, reason as string (#244)

### Features

* add transaction propagation
([#212](#212))
([1d251ff](1d251ff))
* errorCode as enum, reason as string
([#244](#244))
([ce7c4ad](ce7c4ad))
* experimental web support
([#200](#200))
([fd144bb](fd144bb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 11, 2022
lukas-reining pushed a commit that referenced this pull request Jun 29, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants