-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in-memory provider for sdk testing #192
feat: in-memory provider for sdk testing #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 78.99% 78.63% -0.36%
==========================================
Files 9 10 +1
Lines 1076 1203 +127
==========================================
+ Hits 850 946 +96
- Misses 204 230 +26
- Partials 22 27 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0459d87
to
f9f4b29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very straightforward. It's pretty much convinced me we should do this everywhere.
76d9b6c
to
a8c2838
Compare
Perhaps we should add the |
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
a8c2838
to
b2d2084
Compare
For this PR, coverage complaint is on newly added in-memory providers. Some of the error paths are not covered with tests but IMO these are not essential (ex:- testing errors for each flag type) |
This PR
Is related to OFEP open-feature/ofep#71 and shows the feasibility of an in-memory provider
Features
[1] - open-feature/ofep#71
[2] - https://github.com/open-feature/go-sdk/pull/192/files#diff-1e56a5f9a72a9694aeb6f3510e8a2e02359c3cbdb9bd5c906219e30756d857efR181