Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added custom grpc resolver #587

Conversation

pradeepbbl
Copy link
Member

This PR

added custom grpc resolver support in flagd provider

  • support gRPC custom resolver using new config options TragetUri

Related Issues

Fixes #585

Notes

Follow-up Tasks

  • after core update update the branch

How to test

TODO

@pradeepbbl pradeepbbl requested a review from a team as a code owner October 14, 2024 23:45
@pradeepbbl pradeepbbl marked this pull request as draft October 14, 2024 23:45
@pradeepbbl pradeepbbl force-pushed the pmishra/585_flagd_support_custom_resolver branch 3 times, most recently from 5312cce to ced3d71 Compare October 29, 2024 05:16
added custom grpc resolver support in `flagd` provider

Signed-off-by: Pradeep <[email protected]>
Signed-off-by: Pradeep <[email protected]>
@pradeepbbl pradeepbbl marked this pull request as ready for review October 29, 2024 05:25
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering about the Go version bump. The rest of the PR looks great. Thanks!

providers/flagd/go.mod Outdated Show resolved Hide resolved
@pradeepbbl pradeepbbl force-pushed the pmishra/585_flagd_support_custom_resolver branch from 04cbefa to 378d525 Compare October 29, 2024 16:22
@pradeepbbl
Copy link
Member Author

I'm just wondering about the Go version bump. The rest of the PR looks great. Thanks!

thanks for the catch reverted the version bump

@pradeepbbl pradeepbbl force-pushed the pmishra/585_flagd_support_custom_resolver branch from 378d525 to 348f278 Compare October 29, 2024 16:25
@toddbaert toddbaert self-requested a review October 29, 2024 17:40
@toddbaert toddbaert merged commit e509afa into open-feature:main Oct 29, 2024
5 checks passed
@pradeepbbl pradeepbbl deleted the pmishra/585_flagd_support_custom_resolver branch October 29, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flagd] Support custom schemes (name resolvers)
5 participants