-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added custom grpc resolver #587
Merged
toddbaert
merged 4 commits into
open-feature:main
from
bookingcom:pmishra/585_flagd_support_custom_resolver
Oct 29, 2024
Merged
feat: added custom grpc resolver #587
toddbaert
merged 4 commits into
open-feature:main
from
bookingcom:pmishra/585_flagd_support_custom_resolver
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bacherfl,
Kavindu-Dodan and
toddbaert
October 14, 2024 23:45
pradeepbbl
force-pushed
the
pmishra/585_flagd_support_custom_resolver
branch
3 times, most recently
from
October 29, 2024 05:16
5312cce
to
ced3d71
Compare
added custom grpc resolver support in `flagd` provider Signed-off-by: Pradeep <[email protected]>
Signed-off-by: Pradeep <[email protected]>
beeme1mr
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering about the Go version bump. The rest of the PR looks great. Thanks!
toddbaert
reviewed
Oct 29, 2024
pradeepbbl
force-pushed
the
pmishra/585_flagd_support_custom_resolver
branch
from
October 29, 2024 16:22
04cbefa
to
378d525
Compare
thanks for the catch reverted the version bump |
Signed-off-by: Pradeep <[email protected]>
pradeepbbl
force-pushed
the
pmishra/585_flagd_support_custom_resolver
branch
from
October 29, 2024 16:25
378d525
to
348f278
Compare
Signed-off-by: Pradeep <[email protected]>
beeme1mr
approved these changes
Oct 29, 2024
toddbaert
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
added custom grpc resolver support in
flagd
providerTragetUri
Related Issues
Fixes #585
Notes
Follow-up Tasks
How to test
TODO