-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor json logic evaluator to pass custom operators as options #684
chore: refactor json logic evaluator to pass custom operators as options #684
Conversation
Signed-off-by: Florian Bacher <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #684 +/- ##
=======================================
Coverage ? 73.77%
=======================================
Files ? 26
Lines ? 2601
Branches ? 0
=======================================
Hits ? 1919
Misses ? 610
Partials ? 72
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
FYI I think the lint error that's appeared is a bug/false positive. |
Unfortunately cannot reopen the PR. This is discussed here : isaacs/github#361 let's open a new PR to get this through |
Yeah, my bad. I thought closing and reopening the PR would fix the GitHub action issue. |
Closes #667
This PR moves the registration of the custom JSON evaluators out of the
NewJSONEvaluator
method, and allows to pass the custom evaluators as options to theNew
function. This way, theJSONEvaluator
does not need to be aware of the custom evaluations and reduces its responsibility to just providing the means to execute jsonLogic evaluations, based on its store and the flag configurations.