fix: fix connect error code handling for disabled flags #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
==========================================
+ Coverage 73.39% 73.77% +0.38%
==========================================
Files 25 25
Lines 2439 2437 -2
==========================================
+ Hits 1790 1798 +8
+ Misses 583 573 -10
Partials 66 66
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
reviewed
May 24, 2023
toddbaert
reviewed
May 24, 2023
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
force-pushed
the
fix/error-code-handling
branch
from
d2b4711
to
2adcbbd
Compare
|
Updated error message - |
toddbaert
approved these changes
May 25, 2023
beeme1mr
approved these changes
May 25, 2023
Merged
beeme1mr
pushed a commit
that referenced
this pull request
Jun 7, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.5.4</summary> ## [0.5.4](flagd/v0.5.3...flagd/v0.5.4) (2023-06-07) ### 🧹 Chore * update otel dependencies ([#649](#649)) ([2114e41](2114e41)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.3 ([#634](#634)) ([1bc7e99](1bc7e99)) * **deps:** update module github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.12 ([#635](#635)) ([fe88061](fe88061)) * **deps:** update module github.com/open-feature/go-sdk-contrib/tests/flagd to v1.2.2 ([#651](#651)) ([9776973](9776973)) ### ✨ New Features * telemetry improvements ([#653](#653)) ([ea02cba](ea02cba)) ### 🔄 Refactoring * introduce additional linting rules + fix discrepancies ([#616](#616)) ([aef0b90](aef0b90)) </details> <details><summary>flagd-proxy: 0.2.4</summary> ## [0.2.4](flagd-proxy/v0.2.3...flagd-proxy/v0.2.4) (2023-06-07) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.5.3 ([#634](#634)) ([1bc7e99](1bc7e99)) ### 🧹 Chore * update otel dependencies ([#649](#649)) ([2114e41](2114e41)) ### ✨ New Features * telemetry improvements ([#653](#653)) ([ea02cba](ea02cba)) ### 🔄 Refactoring * introduce additional linting rules + fix discrepancies ([#616](#616)) ([aef0b90](aef0b90)) * introduce isyncstore interface ([#660](#660)) ([c0e2fa0](c0e2fa0)) </details> <details><summary>core: 0.5.4</summary> ## [0.5.4](core/v0.5.3...core/v0.5.4) (2023-06-07) ### ✨ New Features * add `sem_ver` jsonLogic evaluator ([#675](#675)) ([a8d8ab6](a8d8ab6)) * add `starts_with` and `ends_with` json evaluators ([#658](#658)) ([f932b8f](f932b8f)) * telemetry improvements ([#653](#653)) ([ea02cba](ea02cba)) ### 🐛 Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.8.0 ([#683](#683)) ([13bb13d](13bb13d)) * **deps:** update module github.com/bufbuild/connect-opentelemetry-go to v0.3.0 ([#669](#669)) ([e899435](e899435)) * **deps:** update module github.com/prometheus/client_golang to v1.15.1 ([#636](#636)) ([b22279d](b22279d)) * **deps:** update module github.com/stretchr/testify to v1.8.3 ([#662](#662)) ([2e06d58](2e06d58)) * **deps:** update module github.com/stretchr/testify to v1.8.4 ([#678](#678)) ([ca8c9d6](ca8c9d6)) * **deps:** update module golang.org/x/mod to v0.10.0 ([#682](#682)) ([16199ce](16199ce)) * **deps:** update module golang.org/x/net to v0.10.0 ([#644](#644)) ([ccd9d35](ccd9d35)) * **deps:** update module golang.org/x/sync to v0.2.0 ([#638](#638)) ([7f4a7db](7f4a7db)) * **deps:** update module google.golang.org/grpc to v1.55.0 ([#640](#640)) ([c0d7328](c0d7328)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.15.0 ([#665](#665)) ([9490ed6](9490ed6)) * fix connect error code handling for disabled flags ([#670](#670)) ([86a8012](86a8012)) * remove disabled flags from bulk evaluation ([#672](#672)) ([d2ce988](d2ce988)) ### 🔄 Refactoring * introduce additional linting rules + fix discrepancies ([#616](#616)) ([aef0b90](aef0b90)) * introduce isyncstore interface ([#660](#660)) ([c0e2fa0](c0e2fa0)) ### 🧹 Chore * refactor json logic evaluator to pass custom operators as options ([#691](#691)) ([1c9bff9](1c9bff9)) * update otel dependencies ([#649](#649)) ([2114e41](2114e41)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
fixes #668
Fixes incorrect error code mapping, which resulted in error message
error code: PROVIDER_NOT_READY: connection not madeWith fix, the error code is set to unknown (as there is no appropriate error code for this error) , and results in message
openfeature: GENERAL: unknown: FLAG_DISABLED