feat: move json logic operator registration to resolver #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 73.69% 77.41% +3.72%
==========================================
Files 32 20 -12
Lines 3140 1612 -1528
==========================================
- Hits 2314 1248 -1066
+ Misses 717 282 -435
+ Partials 109 82 -27 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
force-pushed
the
feat/bind-custom-json-logic-operators-to-resolver
branch
from
5d010e2
to
1c51074
Compare
Merged
Kavindu-Dodan
pushed a commit
that referenced
this pull request
Apr 19, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.10.1</summary> ## [0.10.1](flagd/v0.10.0...flagd/v0.10.1) (2024-04-19) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.9.0 ([#1281](#1281)) ([3cfb052](3cfb052)) ### ✨ New Features * move json logic operator registration to resolver ([#1291](#1291)) ([b473457](b473457)) </details> <details><summary>flagd-proxy: 0.6.1</summary> ## [0.6.1](flagd-proxy/v0.6.0...flagd-proxy/v0.6.1) (2024-04-19) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.9.0 ([#1281](#1281)) ([3cfb052](3cfb052)) </details> <details><summary>core: 0.9.1</summary> ## [0.9.1](core/v0.9.0...core/v0.9.1) (2024-04-19) ### 🐛 Bug Fixes * missing/nil custom variables in fractional operator ([#1295](#1295)) ([418c5cd](418c5cd)) ### ✨ New Features * move json logic operator registration to resolver ([#1291](#1291)) ([b473457](b473457)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Attempts to isolate Resolver creation and related logic into a single component.
Previously, custom Json logic operator registration was done at flagd using
WithEvaluatoroption . But this adds confusion when Resolver needs to be reused in another component. Further the option was merely adding the custom operator to json logic through its global methods and did not perform anything on the evaluator . Given that Resolver is responsible for flag resolving (core logic of the flag evaluations), I have deprecatedWithEvaluatoroption and added custom json logic registration as part of the resolver constructor.I have not removed
JSONEvaluatorOptionoption so we have flexibility to support any future option (ex:-option to have a customizedIResolverimplemetnation )