fix: various edge cases in targeting #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
beeme1mr,
thisthat,
bacherfl and
Kavindu-Dodan
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
toddbaert
commented
Nov 30, 2023
docs/reference/specifications/custom-operations/fractional-operation-spec.md
Show resolved
Hide resolved
toddbaert
commented
Nov 30, 2023
docs/reference/specifications/custom-operations/fractional-operation-spec.md
Show resolved
Hide resolved
toddbaert
commented
Nov 30, 2023
docs/reference/specifications/custom-operations/semver-operation-spec.md
Show resolved
Hide resolved
toddbaert
commented
Nov 30, 2023
docs/reference/specifications/custom-operations/string-comparison-operation-spec.md
Show resolved
Hide resolved
Approved, to me it makes sense to be more specific here, and I agree that for boolean results returning |
toddbaert
changed the title
toddbaert
force-pushed
the
docs/improve-spec-precision
branch
2 times, most recently
from
1abec3d
to
d355b77
Compare
Signed-off-by: Todd Baert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
- Coverage 72.17% 71.87% -0.30%
==========================================
Files 28 28
Lines 2864 2866 +2
==========================================
- Hits 2067 2060 -7
- Misses 695 701 +6
- Partials 102 105 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
|
@bacherfl please re-review when you can. |
toddbaert
commented
Dec 4, 2023
toddbaert
commented
Dec 4, 2023
Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
approved these changes
Dec 4, 2023
Kavindu-Dodan
approved these changes
Dec 4, 2023
toddbaert
changed the title
beeme1mr
approved these changes
Dec 4, 2023
docs/reference/specifications/custom-operations/semver-operation-spec.md
Show resolved
Hide resolved
toddbaert
commented
Dec 4, 2023
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
reviewed
Dec 4, 2023
thisthat
reviewed
Dec 5, 2023
bacherfl
reviewed
Dec 5, 2023
bacherfl
reviewed
Dec 5, 2023
bacherfl
reviewed
Dec 5, 2023
There was a problem hiding this comment.
thanks for the update @toddbaert - conceptually that makes perfect sense. just had some minor suggestions regarding the code, but when those are fixed this PR should be good to go :)
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Merged
toddbaert
pushed a commit
that referenced
this pull request
Dec 5, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.7.2</summary> ## [0.7.2](flagd/v0.7.1...flagd/v0.7.2) (2023-12-05) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.1 ([#1037](#1037)) ([0ed9b68](0ed9b68)) </details> <details><summary>flagd-proxy: 0.3.2</summary> ## [0.3.2](flagd-proxy/v0.3.1...flagd-proxy/v0.3.2) (2023-12-05) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.1 ([#1037](#1037)) ([0ed9b68](0ed9b68)) </details> <details><summary>core: 0.7.2</summary> ## [0.7.2](core/v0.7.1...core/v0.7.2) (2023-12-05) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/open-feature-operator to v0.5.0 ([#1039](#1039)) ([eb128d9](eb128d9)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.5.1 ([#1046](#1046)) ([0321935](0321935)) * **deps:** update module golang.org/x/crypto to v0.16.0 ([#1033](#1033)) ([b79aaf2](b79aaf2)) * **deps:** update module golang.org/x/net to v0.19.0 ([#1034](#1034)) ([c6426b2](c6426b2)) * various edge cases in targeting ([#1041](#1041)) ([ca38c16](ca38c16)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While discussing this, @beeme1mr and I realized it was worth adding a bit more precision here. Please let me know what you folks think, particularly @Kavindu-Dodan and @bacherfl who helped implement some of these.
The main reason this is important, is I will be creating some "negative" gherkin tests to make sure bad inputs and mis-configurations behave consistently across all flagd engine implementations.
Update: new gherkin is here.