Skip to content

Commit

Permalink
chore: fix lint errors (#987)
Browse files Browse the repository at this point in the history
Fixes a few lint issues, directly, and by ignoring some submodules.

---------

Signed-off-by: Todd Baert <[email protected]>
  • Loading branch information
toddbaert authored Nov 2, 2023
1 parent 3d2cd1f commit 0c3af2d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ run:
skip-dirs:
- (^|/)bin($|/)
- (^|/)examples($|/)
- (^|/)schemas($|/)
- (^|/)test-harness($|/)
linters:
enable:
- asciicheck
Expand Down
13 changes: 7 additions & 6 deletions flagd/cmd/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const (
sourcesFlagName = "sources"
syncProviderFlagName = "sync-provider"
uriFlagName = "uri"
docsLinkConfiguration = "https://flagd.dev/reference/flagd-cli/flagd_start/"

defaultServicePort = 8013
defaultMetricsPort = 8014
Expand Down Expand Up @@ -117,18 +118,18 @@ var startCmd = &cobra.Command{
rtLogger.Info(fmt.Sprintf("flagd version: %s (%s), built at: %s", Version, Commit, Date))

if viper.GetString(syncProviderFlagName) != "" {
rtLogger.Warn("DEPRECATED: The --sync-provider flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md")
rtLogger.Warn("DEPRECATED: The --sync-provider flag has been deprecated, see: " +
docsLinkConfiguration)
}

if viper.GetString(evaluatorFlagName) != "json" {
rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md")
rtLogger.Warn("DEPRECATED: The --evaluator flag has been deprecated, see: " +
docsLinkConfiguration)
}

if viper.GetString(providerArgsFlagName) != "" {
rtLogger.Warn("DEPRECATED: The --sync-provider-args flag has been deprecated. " +
"Docs: https://github.com/open-feature/flagd/blob/main/docs/configuration/configuration.md")
rtLogger.Warn("DEPRECATED: The --sync-provider-args flag has been deprecated, see: " +
docsLinkConfiguration)
}

syncProviders, err := runtime.ParseSyncProviderURIs(viper.GetStringSlice(uriFlagName))
Expand Down

0 comments on commit 0c3af2d

Please sign in to comment.