fix: [backport] Should map metadata when converting from ResolutionDetails to FlagEvaluationDetails #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agEvaluationDetails Signed-off-by: Benjamin Evenson <[email protected]>
Signed-off-by: Benjamin Evenson <[email protected]>
askpt
approved these changes
Jul 26, 2024
toddbaert
approved these changes
Jul 26, 2024
beeme1mr
pushed a commit
that referenced
this pull request
Jul 26, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.2](v1.5.1...v1.5.2) (2024-07-26) ### 🐛 Bug Fixes * [backport] Should map metadata when converting from ResolutionDetails to FlagEvaluationDetails ([#285](#285)) ([d6d1d94](d6d1d94)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
When converting the ResolutionDetails to FlagEvalutionDetails we aren't passing the FlagMetadata to the new object.
Related Issues
Fixes #1234523
Notes
This PR is done on a common merge base so we can merge it into v1 as well
Follow-up Tasks
N/A
How to test
Unit test added to covert the missing test case