(WIP) Graded library content - Do not merge, for internal review #3
Conversation
…e (belongs on subsection/sequential)
Allows modules with 'always_recalculate_grades' to use their children's state when computing their grade via grades.grade()
…ldn't even be an enum anymore?
| branch = key.course_key.branch | ||
| if branch is None or branch == ModuleStoreEnum.BranchName.draft: | ||
| return True # This is the default branch, so strip out branch from any locators | ||
| return False # This is not the default branch - we must leave branch information in |
There was a problem hiding this comment.
This feels hackier still than in #1 . Would it make sense to clean this up, ie not having get_item removing the branch ever, and fixing the higher-level code that relies on this instead? I imagine it would likely be a lot of work, but if we can leave the place cleaner after us, it will be appreciated.
There was a problem hiding this comment.
I had to make this change because my earlier code broke the Acid XBlock in studio. I agree it's less than ideal.
About changing it in the modulestore: we would need to discuss that with upstream, probably Don. It's a small change code-wise that could have a lot of big implications throughout the codebase.
There was a problem hiding this comment.
Thinking about this some more: If we're using a new "LibraryLocator" to reference libraries, then we won't have a special branch, so this code may not be needed at all :)
I'll investigate more today.
There was a problem hiding this comment.
@antoviaque Yep, good news: I have developed a prototype of new locators for the Content Libraries, and with that change, this code (and the other remove_branch stuff you were questioning) is no longer needed at all.
There was a problem hiding this comment.
Great : ) And thank you for the other answers, it useful to read the explanations.
|
Superseded by #5. |
Add French translations and hide course number in the page header.
…dback-update-3 Hash Update #3: Diagnostic-Feedback
Fix pip dependencies broken since ginkgo.1, and mongo replicaset read_preference
This is a continuation of the prototype found in #2, extended to implement SOL-19 "As a student, when I complete interactive exercises displayed in a LibraryContent block in the LMS, I see a single aggregated grade for the set of exercises in the progress tab."
Testing instructions: Follow same testing steps as #2, except on step 7 when adding content to the library, add problems (of any type). On step 10, be sure to set "Scored" to True. Then, after all the other steps, view the course as a student. Check that the "Progress" tab is correct, before and after submitting answers to the problems. Test the weighting and make sure none of the children appear in the progress view - only the combined score of the LibraryContent block.
Library screenshot:
LMS screenshot: