SE-3126 Fix issue caused by XSS fix in Video > Advanced > Transcript Languages #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkulkark
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
Thanks @pomegranited. This works perfectly! I just noticed that the HtmlUtils method should actually be prepend and not append (the code before the patch was using prepend and the styling is off with append). So I went ahead and pushed the change.
- I tested this: Verified the transcript languages setting works as described in the testing instructions.
- I read through the code.
-
I tested for accessibilityN/A -
Includes documentationN/A
|
Thanks for that @pkulkark ! I've re-tested on my devstack with Merging now.. |
lgp171188
pushed a commit
that referenced
this pull request
Aug 20, 2020
…Languages (#240) * Fix issue caused by XSS fix in Video > Advanced > Transcript Languages * change append to prepend Co-authored-by: pkulkark <[email protected]> (cherry picked from commit 6eeb1846e260173d5e327aa600f5c3897220fd31)
lgp171188
pushed a commit
that referenced
this pull request
Aug 20, 2020
…Languages (#240) * Fix issue caused by XSS fix in Video > Advanced > Transcript Languages * change append to prepend Co-authored-by: pkulkark <[email protected]>
toxinu
pushed a commit
that referenced
this pull request
Sep 16, 2020
…Languages (#240) * Fix issue caused by XSS fix in Video > Advanced > Transcript Languages * change append to prepend Co-authored-by: pkulkark <[email protected]>
viadanna
pushed a commit
that referenced
this pull request
Dec 15, 2020
…Languages (#240) * Fix issue caused by XSS fix in Video > Advanced > Transcript Languages * change append to prepend Co-authored-by: pkulkark <[email protected]>
gabor-boros
pushed a commit
that referenced
this pull request
Feb 10, 2022
…_safe fix: ensure redirect url is whitelisted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced by #237 code ported from upstream.
Screenshots
Before this fix:
After this fix:
Sandbox
Testing instructions
.srtfile..srtfile downloaded in the previous step..srtfile you uploaded remains saved with the video.Reviewer