Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow enrollment into 'invite-only' courses #7

Conversation

tecoholic
Copy link
Member

This adds a new flag to the EnterpriseCustomer model that can be used to allow users to enroll into "Invitation Only" courses by visiting the enterprise enrollment URL without being explicityly invited by course instructors.

Internal-Ref: https://tasks.opencraft.com/browse/BB-7619

Nutmeg backport of openedx#1813

This adds a new flag to the EnterpriseCustomer model that can be used to
allow users to enroll into "Invitation Only" courses by visiting the
enterprise enrollment URL without being explicityly invited by course
instructors.

Internal-Ref: https://tasks.opencraft.com/browse/BB-7619
@tecoholic tecoholic self-assigned this Jul 24, 2023
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tecoholic,

  1. Why did we update package-lock.json?
  2. Please bump the version in this PR.
  3. Also, the same nits as in the upstream PR.

👍

  • I tested this: in the upstream PR
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@tecoholic
Copy link
Member Author

@Agrendalath Thank you for the review

1. Why did we update `package-lock.json`?

I didn't notice that this file was modified. I think the "make test" must have installed the packages and update it. Anyways, I rolled back the changes on this one.

2. Please bump the version in this PR.

Done.

3. Also, the same nits as in the upstream PR.

Done.

@tecoholic tecoholic merged commit 65cee2c into opencraft-release/nutmeg.2 Aug 3, 2023
5 of 6 checks passed
@tecoholic tecoholic deleted the tecoholic/BB-7619-create-cea-before-checkout-nutmeg-backport branch August 3, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants