-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-elasticache): add ServerlessCache, User, and UserGroup L2 Constructs #57
feat(aws-elasticache): add ServerlessCache, User, and UserGroup L2 Constructs #57
Conversation
2c20221
to
0f45a2f
Compare
There are several validations and configurations that are not documented in the CFn documentation but have been added based on observations from the management console. I've left these as review comments, so please resolve if there are no problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More general would be better.
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]> Signed-off-by: Matsuda <[email protected]>
...integ.elasticache-serverless-cache.ts.snapshot/ElastiCacheServerlessCacheStack.template.json
Outdated
Show resolved
Hide resolved
Did we get all the threads resolved? (let me know if I missed any) I think I've seen everything else, nothing appears to be wrong (which is so great). |
Thank you. |
@go-to-k Please let me know if this looks good to you. |
Looks good. May we merge this PR? |
Thank you. I would appreciate it if you could proceed with the merge. |
Issue # (if applicable)
Closes #55.
Reason for this change
To support Serveless Cache L2 Construct.
Description of changes
Ad the following Constructs
Description of how you validated changes
Add unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license