Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-elasticache): add ServerlessCache, User, and UserGroup L2 Constructs #57

Merged
merged 77 commits into from
Jan 16, 2025

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Oct 12, 2024

Issue # (if applicable)

Closes #55.

Reason for this change

To support Serveless Cache L2 Construct.

Description of changes

Ad the following Constructs

  • ServerlessCache
  • User
  • UserGroup

Description of how you validated changes

Add unit tests and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

src/aws-elasticache/user.ts Outdated Show resolved Hide resolved
src/aws-elasticache/user.ts Outdated Show resolved Hide resolved
src/aws-elasticache/user.ts Outdated Show resolved Hide resolved
src/aws-elasticache/user.ts Outdated Show resolved Hide resolved
src/aws-elasticache/user.ts Outdated Show resolved Hide resolved
@mazyu36 mazyu36 force-pushed the elasticache-serverless branch from 2c20221 to 0f45a2f Compare October 16, 2024 22:45
@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 16, 2024

There are several validations and configurations that are not documented in the CFn documentation but have been added based on observations from the management console.

I've left these as review comments, so please resolve if there are no problems.

@mazyu36 mazyu36 marked this pull request as ready for review October 16, 2024 22:57
@go-to-k go-to-k changed the title feat(elasticache): Add ServerlessCache, User, and UserGroup L2 Costruct feat(elasticache): ServerlessCache, User, and UserGroup L2 Constructs Jan 14, 2025
@go-to-k go-to-k changed the title feat(elasticache): ServerlessCache, User, and UserGroup L2 Constructs feat(elasticache): add ServerlessCache, User, and UserGroup L2 Constructs Jan 14, 2025
@go-to-k go-to-k changed the title feat(elasticache): add ServerlessCache, User, and UserGroup L2 Constructs feat(aws-elasticache): add ServerlessCache, User, and UserGroup L2 Constructs Jan 14, 2025
src/aws-elasticache/user-group.ts Outdated Show resolved Hide resolved
src/aws-elasticache/serverless-cache.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More general would be better.

src/aws-elasticache/README.md Outdated Show resolved Hide resolved
src/aws-elasticache/README.md Outdated Show resolved Hide resolved
mazyu36 and others added 7 commits January 15, 2025 16:23
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Matsuda <[email protected]>
Co-authored-by: Kenta Goto (k.goto) <[email protected]>
Signed-off-by: Matsuda <[email protected]>
@go-to-k
Copy link
Contributor

go-to-k commented Jan 15, 2025

Did we get all the threads resolved? (let me know if I missed any)

I think I've seen everything else, nothing appears to be wrong (which is so great).
I'll merge this PR if you are OK, but I'd like you to give me a final check just to be sure.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 15, 2025

Thank you.
I have addressed all the comments, but I will double-check everything tomorrow and get back to you.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 16, 2025

@go-to-k
I fixed several typos in the README.
I also improved the explanation and implementation samples for the original default user that is automatically created in AWS.
Additionally, I added an integration test for the original default user.

Please let me know if this looks good to you.

@go-to-k
Copy link
Contributor

go-to-k commented Jan 16, 2025

Looks good. May we merge this PR?

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jan 16, 2025

Thank you. I would appreciate it if you could proceed with the merge.

@go-to-k go-to-k added this pull request to the merge queue Jan 16, 2025
Merged via the queue into open-constructs:main with commit 4bef4a7 Jan 16, 2025
6 checks passed
@mazyu36 mazyu36 deleted the elasticache-serverless branch January 16, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticache: Add L2 Construct for ElastiCache Serverless
3 participants