Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples credentials ocmconfig #323

Merged
merged 40 commits into from
Sep 16, 2024
Merged

examples credentials ocmconfig #323

merged 40 commits into from
Sep 16, 2024

Conversation

ikhandamirov
Copy link
Contributor

@ikhandamirov ikhandamirov commented Sep 6, 2024

What this PR does / why we need it:

This PR enhances documentation with basic examples of credentials configuration for a few most common artifact repository types via .ocmconfig file.

Which issue(s) this PR fixes:

Fixes open-component-model/ocm-project#246

@ikhandamirov ikhandamirov changed the title examples credentials ocmconfig [DO NOT MERGE] examples credentials ocmconfig Sep 6, 2024
@ikhandamirov
Copy link
Contributor Author

@hilmarf do you have working ocmconfig to configure access to maven and npm repositories? I'd like to add it to this page (after some obfuscation) as examples.

@hilmarf hilmarf added this to the 2024-Q3 milestone Sep 9, 2024
@ikhandamirov ikhandamirov marked this pull request as draft September 9, 2024 11:11
@ikhandamirov ikhandamirov changed the title [DO NOT MERGE] examples credentials ocmconfig examples credentials ocmconfig Sep 9, 2024
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace mandelsoft with open-component-model ?

content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
@ikhandamirov ikhandamirov marked this pull request as ready for review September 12, 2024 12:35
@ikhandamirov ikhandamirov dismissed hilmarf’s stale review September 12, 2024 12:43

The requested changes have been implemented

hilmarf
hilmarf previously approved these changes Sep 12, 2024
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
content/docs/examples/creds-in-ocmconfig.md Outdated Show resolved Hide resolved
ikhandamirov and others added 2 commits September 13, 2024 11:00
Co-authored-by: Frederic Wilhelm <[email protected]>
@morri-son morri-son enabled auto-merge (squash) September 16, 2024 10:11
n-boshnakov
n-boshnakov previously approved these changes Sep 16, 2024
Copy link
Contributor

@n-boshnakov n-boshnakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

morri-son
morri-son previously approved these changes Sep 16, 2024
Copy link
Contributor

@morri-son morri-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@morri-son morri-son merged commit c8407c6 into main Sep 16, 2024
1 of 3 checks passed
@morri-son morri-son deleted the examples-creds-ocmconfig branch September 16, 2024 14:31
@morri-son
Copy link
Contributor

@ikhandamirov , can you please move this from "examples" to "tutorials" on the website?

@ikhandamirov
Copy link
Contributor Author

@morri-son , moving is easy, but... Those are really examples, not step-by-step tutorials. It is by intention under "examples".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

Credential Management Examples
6 participants