Functionize reconcile loops and add comments on functions

[morri-son]

Functionize reconcile loops and add comments on functions:

• The reconcile loops are the most important functions in the controllers and most of the functional/business cases for the ocm/mpas concept flow are defined here.

• Almost all reconcile loops in controllers are written like scripts

• Extract each important step to a function makes the flow easier to read, easier to review if somebody removes some code and each function can have comments on top to describe the functionality if required

• Ideal implementation:

  • https://github.com/open-component-model/mpas-project-controller/blob/main/controllers/project_controller.go#L110

• Example for necessary code improvement:

  • https://github.com/open-component-model/ocm-controller/blob/main/controllers/componentversion_controller.go#L192
  • https://github.com/open-component-model/ocm-controller/blob/main/controllers/resource_controller.go#L173
  • https://github.com/open-component-model/mpas-product-controller/blob/main/controllers/productdeploymentgenerator_controller.go#L176 (230 line function)
  • https://github.com/open-component-model/mpas-product-controller/blob/main/controllers/validation_controller.go#L79

[phoban01]

The reconcile loops are the most important functions in the controllers and most of the functional/business cases for the ocm/mpas concept flow are defined here.

Almost all reconcile loops in controllers are written like scripts

This is not useful information in order to help us improve the project.

@shivenduverma-sap please make Pull Requests where you see areas for improvement rather than providing links to code that does or does not meet your standards.

[robertwol]

related open-component-model/ocm-controller#242

[morri-son]

@Skarlso , since Shivendu left, can you please go over the mentioned issues and transfer them into PRs / dedicated issues and then close this one?